Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 10, 2025

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl mentioned this pull request Apr 10, 2025
@lcawl lcawl requested a review from a team April 10, 2025 16:16
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 28/28 28/28

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍅

(cherry picked from commit 90fbed0)
@lcawl lcawl force-pushed the backport/9.0/pr-4255 branch from 4210731 to 7c5f52a Compare April 11, 2025 22:20
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 28/28 28/28

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit c90fbe3 into 9.0 Apr 11, 2025
7 checks passed
@lcawl lcawl deleted the backport/9.0/pr-4255 branch April 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants